Skip to content

Bump redb to v4.1.0 - #28

Merged
110CodingP merged 2 commits into
masterfrom
redb_3
Aug 1, 2026
Merged

Bump redb to v4.1.0#28
110CodingP merged 2 commits into
masterfrom
redb_3

Conversation

@110CodingP

@110CodingP 110CodingP commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Since redb incorporated changes to the serialization format in v3.0 and v4.0, the changes in this PR are BACKWARDS INCOMPATIBLE.

@coveralls

coveralls commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 97.695%. remained the same — redb_3 into master

@notmandatory

Copy link
Copy Markdown
Collaborator

would it make sense to just jump ahead to redb 4.1 ? it looks like it has a bunch of bug fixes:

https://github.com/cberner/redb/releases/tag/v4.1.0

@110CodingP 110CodingP changed the title Bump redb to v3.1.3 Bump redb to v4.1.0 Jun 28, 2026
@110CodingP
110CodingP marked this pull request as ready for review June 28, 2026 14:19
Because of redb 4.1.0 requires at least rustc 1.89
@110CodingP

Copy link
Copy Markdown
Owner Author

🤖 Code Review by Antigravity

Pull Request: #28build: bump redb version and MSRV
Review Status: 🟢 Approved with Suggestion


📝 Summary of Review

This PR updates bdk_redb to depend on redb v4.1.0, bumps the library version to 0.3.0 due to public API breaking changes (pub use redb;), and elevates the Minimum Supported Rust Version (MSRV) from 1.85.0 to 1.89.0 (required by redb 4.1.0).


✅ Verification Checklist

  • Compilation: cargo check --all-targets --all-features passed without errors.
  • Unit & Integration Tests:
    • cargo test --all-features passed (25 unit tests, 1 doctest).
    • cargo test --no-default-features passed (22 unit tests, 1 doctest).
  • Linter: cargo clippy --all-targets --all-features passed with zero warnings.
  • Documentation: cargo doc --all-features built cleanly without warnings.
  • SemVer Rules: Version bumped to 0.3.0 appropriately reflecting redb major version bump.

🔍 Detailed File-by-File Review

1. Cargo.toml

  • Changes: Bumps redb to "4", rust-version to "1.89.0", and bdk_redb crate version to "0.3.0".
  • Feedback: ✅ Looks good. Correctly reflects breaking change rules and minimum toolchain requirement.

2. src/lib.rs

  • Changes:
    • Adds ReadableDatabase trait to imports from redb.
    • Updates crate-level documentation example (bdk_redb = "0.3.0", adds Database and Store imports, removes deprecated .extract_keys()).
  • Feedback: ✅ Necessary for trait method resolution in redb 4.x and keeps documentation code snippet working and runnable.

3. .github/workflows/cont_integration.yml, clippy.toml, rust-version

  • Changes: MSRV updated to 1.89.0 across CI matrix, clippy configuration, and rust-version.
  • Feedback: ✅ Good consistency across build & CI files.

⚠️ Suggested Action Item

Warning

README.md has leftover references to Rust 1.85.0

Please update the following lines in README.md to reflect 1.89.0:

  • Line 4: [![Rustc Version 1.85.0+](https://img.shields.io/badge/rustc-1.85.0%2B-yellow.svg)]... -> Change 1.85.0 to 1.89.0
  • Line 27: "The library maintains a MSRV of 1.85.0 due to dependency on redb." -> Change 1.85.0 to 1.89.0

Reviewed by Antigravity AI Coding Assistant

@110CodingP
110CodingP merged commit 6b1e9e0 into master Aug 1, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants